Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise Data Mappings in Seldon Wrapper #1145

Closed
axsaucedo opened this issue Nov 27, 2019 · 0 comments · Fixed by #1174
Closed

Standardise Data Mappings in Seldon Wrapper #1145

axsaucedo opened this issue Nov 27, 2019 · 0 comments · Fixed by #1174
Assignees
Milestone

Comments

@axsaucedo
Copy link
Contributor

Currently the data conversions from Python data structures into SeldonMessage components (i.e. data, strData, jsonData or binData) are not fully standardised. For example, the only way to retunr a jsonData atm is by sending jsonData as input. A fix would be to set the data to be converted into Dict by default. But it would also be important to consider cases such as when we return "strData" or "binData", as these can be valid jsonData as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant