-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplication of seldon_core_setup notebook #1232
Comments
oh, my bad, it's there but as a markdown cell whereas in other one it is executed directly from notebook, |
The notebooks version is only referenced by a few notebooks so we could shift them to point to I think the seldon_core_setup.html references need to stay as-is as they are just for the web version that refer to the readthedocs page generated from the nblink and the paths on those are different. |
Actually we shouldn't do what I just suggested. When you open a jupyter server with (Actually there's already a risk that people will run this command from a deeper-level directory - perhaps we should open an issue to make it clearer what we intend.) Perhaps the symlink is a better idea. |
When going through seldon-core docs I noticed that
seldon_core_setup.ipynb
is duplicated both in seldon-core/examples and seldon-core/notebooks.The one linked from first tutorial notebook one hit when going through docs leads you to latter one that does not include info about ambassador port forwarding which may be confusing to new users.We could remove duplication by creating a symlink and keeping around only one version of this notebook.
The text was updated successfully, but these errors were encountered: