Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal REST based encoding schemes could be improved #1270

Closed
pisymbol opened this issue Dec 13, 2019 · 1 comment
Closed

Internal REST based encoding schemes could be improved #1270

pisymbol opened this issue Dec 13, 2019 · 1 comment
Milestone

Comments

@pisymbol
Copy link

Looking at the sidecar and prediction service, I noticed that the internal API marshalls requests between the InternalPredictionService to the inference server using x-application-url-encoding. Is that really the right idea?

The reason why is for large payloads the URL encoding scheme is going to suffer for some overhead versus say multipart/form-encoded which I believe is the recommended scheme for file uploads and large payloads in general by the W3C.

Another aspect to all of this is perhaps compressing requests on-the-fly. I realize gRPC is not compressed per se but it does use simple variable length encoding schemes to reduce payload overhead and perhaps Seldon Core can "feature" something similar for the JSON that is passed back and forth between the sidecar and prediction service.

An interesting and I think relevant read: https://eng.uber.com/trip-data-squeeze

@pisymbol pisymbol added the triage Needs to be triaged and prioritised accordingly label Dec 13, 2019
@ukclivecox ukclivecox added this to the 1.1 milestone Dec 16, 2019
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Dec 16, 2019
@ukclivecox
Copy link
Contributor

dup of #1013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants