Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log4j from H2O example #1318

Closed
adriangonz opened this issue Jan 7, 2020 · 0 comments · Fixed by #1319
Closed

Remove log4j from H2O example #1318

adriangonz opened this issue Jan 7, 2020 · 0 comments · Fixed by #1319
Assignees
Labels
Milestone

Comments

@adriangonz
Copy link
Contributor

The pom.xml of the h2o_mojo example model installs a log4j version, which has recently been flagged as insecure.

<dependency>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
<version>1.2.17</version>
</dependency>

Checking out the code, it seems that it's using SLF4J instead, therefore I can't see any reason for log4j to be installed. It should be safe to just remove it.

@adriangonz adriangonz added bug triage Needs to be triaged and prioritised accordingly labels Jan 7, 2020
@adriangonz adriangonz self-assigned this Jan 7, 2020
@adriangonz adriangonz removed the triage Needs to be triaged and prioritised accordingly label Jan 7, 2020
@adriangonz adriangonz added this to the 1.1 milestone Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant