Send back PUID on response

[adriangonz]

The executor generates a Prediction UID (PUID) which is forwarded down to the predictor services. However, it doesn't send this back on the final response. This UID could be useful for the end-user.

Suggested fix

It seems that, at "response time" (i.e. right before sending it back), the PUID is still present in the Go context. Therefore, the problem seems to be that the respondWithSuccess method in rest.SeldonRestApi doesn't serialise it.

seldon-core/executor/api/rest/server.go

Lines 74 to 82 in 946d540

	func (r *SeldonRestApi) respondWithSuccess(w http.ResponseWriter, code int, payload payload.SeldonPayload) {
	w.Header().Set("Content-Type", payload.GetContentType())
	w.WriteHeader(code)
	err := r.Client.Marshall(w, payload)
	if err != nil {
	r.Log.Error(err, "Failed to write response")
	}
	}

Adding there a w.WriteHeader() writing the PUID should be enough.

[adriangonz]

@cliveseldon would there be any other changes required for the gRPC endpoint?

[ukclivecox]

Closing this as fixed.