Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document compatbility of wrapper versions with seldon engine versions #1564

Closed
kparaju opened this issue Mar 19, 2020 · 2 comments · Fixed by #1616
Closed

Document compatbility of wrapper versions with seldon engine versions #1564

kparaju opened this issue Mar 19, 2020 · 2 comments · Fixed by #1616
Assignees
Labels
triage Needs to be triaged and prioritised accordingly
Milestone

Comments

@kparaju
Copy link
Contributor

kparaju commented Mar 19, 2020

When we upgrade the seldon operator which upgrades the seldon engine, we might have docker images that are build with an older python wrapper. Adding a compatibility table of seldon engine and the different wrappers with upgrade notes would be really helpful. Something like:

Engine Python Wrapper Java Wrapper Supported Notes
0.4.2 <1.0 ?
1.1 <1.0 ?

We can start off with something like this and maybe add another column that differentiates between "it works" vs "it works but it's deprecated"

@kparaju kparaju added the triage Needs to be triaged and prioritised accordingly label Mar 19, 2020
@amoldavsky
Copy link
Contributor

Hi, Assaf from Jobcase here, we are planning to upgrade from Seldon-Core 0.1 to 1.0 and we are using Java wrapper 0.1.5. We have a concern that the upgrade may result in us having to shut down the entire cluster because non of the Java wrapper will be compatible with the new version of Seldon-Core.

@adriangonz @axsaucedo @cliveseldon

@axsaucedo axsaucedo added this to the 1.1 milestone Mar 23, 2020
@RafalSkolasinski RafalSkolasinski self-assigned this Mar 23, 2020
@RafalSkolasinski RafalSkolasinski modified the milestones: 1.1, 1.2 Mar 25, 2020
@ukclivecox ukclivecox modified the milestones: 1.2, 1.1 Mar 26, 2020
@ukclivecox
Copy link
Contributor

This is in progress - we will close when available in docs.
https://github.com/SeldonIO/seldon-core/blob/master/doc/source/reference/upgrading.md

We will only show >=1.0 compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs to be triaged and prioritised accordingly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants