Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[document request] Add more technical details about service orchestrator #1596

Closed
gaocegege opened this issue Mar 25, 2020 · 3 comments · Fixed by #1641
Closed

[document request] Add more technical details about service orchestrator #1596

gaocegege opened this issue Mar 25, 2020 · 3 comments · Fixed by #1641
Assignees
Milestone

Comments

@gaocegege
Copy link
Contributor

I am new to Seldon Core but familiar with KFServing. I find that the documentation about the service orchestrator is hard to understand. I cannot get why we need such an orchestrator and how it works.

I think we can improve it. We could have a graph like it and illustrate the workflow of orchestrator and help readers understand the design purpose of it.

serving-Page-5

@gaocegege gaocegege added the triage Needs to be triaged and prioritised accordingly label Mar 25, 2020
@ukclivecox
Copy link
Contributor

ukclivecox commented Mar 25, 2020

Hi @gaocegege I agree better docs for the service orchestrator would be useful.
From 1.1 we will transition to a new GoLang executor for the service orchestrator: see https://github.com/SeldonIO/seldon-core/tree/master/executor

I think your diagram can be used for that as well. Happy to connect to chat.

@gaocegege
Copy link
Contributor Author

Yeah, I notice that we are migrating to golang implementation. The graph I provided here is just used in my company to show the workflow of the orchestrator, not intend to be used by the doc directly.

@gaocegege
Copy link
Contributor Author

BTW, there is a question about https://github.com/SeldonIO/mlgraph . I am wondering why we do not use the executor approach and propose mlgraph in Kubeflow community to implement the infer graph.

Personally, I think the executor is flexible and easy to maintain.

@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Mar 30, 2020
@ukclivecox ukclivecox added this to the 1.1 milestone Mar 30, 2020
@ukclivecox ukclivecox self-assigned this Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants