Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to use Java engine if helm installation defaults to executor #1607

Closed
RafalSkolasinski opened this issue Mar 25, 2020 · 2 comments · Fixed by #1831
Closed

allow to use Java engine if helm installation defaults to executor #1607

RafalSkolasinski opened this issue Mar 25, 2020 · 2 comments · Fixed by #1831
Assignees
Milestone

Comments

@RafalSkolasinski
Copy link
Contributor

If seldon-core is installed using helm with --set executor.enabled=true one cannot deploy a single POD using engine.

In opposite situation, when above is set to false, one can enforce executor with annotations:

spec:
  annotations:
    seldon.io/executor: "true"

P.S. Not sure how much it is important as we are going to deprecate Java engine.

@seldondev
Copy link
Collaborator

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

@seldondev seldondev added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2020
@axsaucedo
Copy link
Contributor

/remove-lifecycle stale
/priority p1
Adding high priority given that this will be quite key for backwards compatibility support

@seldondev seldondev added priority/p1 and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 13, 2020
@RafalSkolasinski RafalSkolasinski self-assigned this May 13, 2020
@axsaucedo axsaucedo added this to the 1.2 milestone May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants