Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong package for YAML #1609

Closed
adriangonz opened this issue Mar 25, 2020 · 0 comments · Fixed by #2010
Closed

Wrong package for YAML #1609

adriangonz opened this issue Mar 25, 2020 · 0 comments · Fixed by #2010
Assignees
@adriangonz
Labels
priority/p1
Milestone
1.2

Comments

@adriangonz
Copy link
Contributor

adriangonz commented Mar 25, 2020 •
edited
Loading

In the setup.py and requirements.txt files of the seldon_core package we are currently installing pyaml as a dependency.

seldon-core/python/setup.py

Line 40 in ee1874c

"pyaml<20.0.0",

However, what we really use seems to be PyYAML. It probably works regardless because pyaml uses PyYAML underneath so it still brings it as a subdependency.
@adriangonz adriangonz added the triage Needs to be triaged and prioritised accordingly label Mar 25, 2020
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Mar 26, 2020
@ukclivecox ukclivecox added this to the 1.2 milestone Mar 26, 2020
@ukclivecox ukclivecox removed this from the 1.2 milestone Apr 23, 2020
@ukclivecox ukclivecox added this to the 1.2 milestone Jun 25, 2020
@adriangonz adriangonz self-assigned this Jun 25, 2020
@adriangonz adriangonz mentioned this issue Jun 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adriangonz adriangonz

Labels
priority/p1
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Use correct YAML package adriangonz/seldon-core
2 participants
@adriangonz @ukclivecox