Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change executor timeouts #1691

Closed
adriangonz opened this issue Apr 14, 2020 · 0 comments · Fixed by #1693
Closed

Change executor timeouts #1691

adriangonz opened this issue Apr 14, 2020 · 0 comments · Fixed by #1693
Assignees
@adriangonz
Labels
bug
Milestone
1.1

Comments

@adriangonz
Copy link
Contributor

Currently, the timeout config for the executor's REST server seems to be hardcoded to 15 seconds. It would be good to set here the value coming from the SeldonDeployment annotations.

seldon-core/executor/api/rest/server.go

Lines 77 to 79 in d84b974

// Good practice: enforce timeouts for servers you create!
WriteTimeout: 15 * time.Second,
ReadTimeout: 15 * time.Second,

@adriangonz adriangonz added bug triage Needs to be triaged and prioritised accordingly and removed triage Needs to be triaged and prioritised accordingly labels Apr 14, 2020
@adriangonz adriangonz added this to the 1.1 milestone Apr 14, 2020
@adriangonz adriangonz self-assigned this Apr 14, 2020
@adriangonz adriangonz mentioned this issue Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adriangonz adriangonz

Labels
bug
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Leave timeouts as default adriangonz/seldon-core
1 participant
@adriangonz