-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
routing metadata missing in new executor #1823
Comments
This may be possible to be done on the wrapper itself. |
Hi @cliveseldon |
We have not had a chance to look at it but plan to discuss to see if it can be in language wrapper and prioritized. |
After reviewing it does not seem it is possible to reconstruct current behaviour on the wrapper only. This is because Changing that behaviour would mean that Alternative solution may be to record @amirclam Would love to hear more about how you are using these in your system. I am mainly interested if you need to know the integer representing the chosen |
@RafalSkolasinski @cliveseldon We are experimenting Seldon-core and mostly interested with multi arm bandit solution, currently we are on Seldon 1.1 and feedback method is available. What is your suggestion? Does the fix included in 1.3 or there is some other workaround on 1.1? |
No, unfortunately not in 1.3.0. |
Ok, thx for quick feedback. And there is no workaround on 1.1, right? |
You could always run with old orchestrator system, the engine, for time being. There is a doc entry on how to set it up. |
@RafalSkolasinski thx for suggestion, I follow the doc you pointed above, re-installed with following command:
Then container log of
Any tips? |
Hi @theone4ever, thanks for reporting that. This is quite unfortunate - could you please open a separate issue about it? |
@RafalSkolasinski sure, but before that just want to double confirm if java engine is still supported in 1.3? In doc here, it says: |
It's considered last resort fallback if for some reason one really, really cannot run with Executor. The above (this issue) seems the only missing piece and we believe only in context of multi-armed bandits... Saying that we don't really develop java engine anymore and are seriously considering fully dropping it (probably with 1.4 though not decided) |
ok, then in 1.3, at least java engine should still work, right @RafalSkolasinski ? In this case, I will report another issue then. |
@theone4ever, yes, please - we briefly looked at your logs and believe that the problem is that your liveness and readiness probes are configured to use https endpoint when in reality they are http ones. But it's better to discuss this in separate issue and keep this one for routing metadata only |
Hey @theone4ever @RafalSkolasinski, I've opened up a new issue with the Java engine issue you described. We can continue the discussion there: #2586 |
Reporter on community slack by user.
As new orchestrator (executor) is not inspecting payloads passed around the graph it is not currently adding the
routing
metadata, e.g.This may be important in context of multi-armed bandits and AB testing.
The text was updated successfully, but these errors were encountered: