Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow globally configurable docker registry secret for seldon deployments #1923

Closed
axsaucedo opened this issue Jun 8, 2020 · 3 comments
Closed

Comments

@axsaucedo
Copy link
Contributor

Currently if seldon is installed in a cluster that needs ot run models with images from a private docker registry that needs credentials, it's necessary to add the existing containerSpec secrets for each deployment. The scope of this issue encompasses the ability to define a set of secrets that should be added by default to all the Seldon Core deployments such that it's used to authenticate with a docker registry.

@axsaucedo axsaucedo added the triage Needs to be triaged and prioritised accordingly label Jun 8, 2020
@axsaucedo
Copy link
Contributor Author

/priority p1

@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Jun 11, 2020
@ryandawsonuk
Copy link
Contributor

@ukclivecox ukclivecox added this to the 1.3 milestone Jun 25, 2020
@axsaucedo axsaucedo modified the milestones: 1.3, 1.2 Jul 9, 2020
@axsaucedo axsaucedo self-assigned this Jul 15, 2020
@ukclivecox ukclivecox modified the milestones: 1.2, 1.3 Jul 21, 2020
@ukclivecox ukclivecox modified the milestones: 1.3, 1.4 Aug 20, 2020
@axsaucedo axsaucedo modified the milestones: 1.4, 1.5 Oct 15, 2020
@ukclivecox ukclivecox modified the milestones: 1.5, 1.6 Nov 30, 2020
@axsaucedo
Copy link
Contributor Author

THis shoudl no longer be required as this can be done by just adding the secret to the service account and attach the service account as per https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#add-image-pull-secret-to-service-account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants