Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify model version for tensorflow serving #1964

Closed
zewelor opened this issue Jun 17, 2020 · 3 comments
Closed

Allow to specify model version for tensorflow serving #1964

zewelor opened this issue Jun 17, 2020 · 3 comments
Labels
triage Needs to be triaged and prioritised accordingly

Comments

@zewelor
Copy link

zewelor commented Jun 17, 2020

Allow to specify model version as shown here https://www.tensorflow.org/tfx/serving/api_rest#predict_api . From looking at the code, currently it doesn't seem possible: https://github.com/SeldonIO/seldon-core/blob/master/integrations/tfserving/TfServingProxy.py#L45

@zewelor zewelor added the triage Needs to be triaged and prioritised accordingly label Jun 17, 2020
@ukclivecox
Copy link
Contributor

If you use 1.1.0 of Seldon you can use the Tensorflow protocol directly. https://docs.seldon.io/projects/seldon-core/en/latest/graph/protocols.html#rest-and-grpc-tensorflow-protocol

Its true we don't expose the version path in REST

r.Router.NewRoute().Path("/v1/models/{" + ModelHttpPathVariable + "}/:predict").Methods("POST").HandlerFunc(r.wrapMetrics(metric.PredictionHttpServiceName, r.predictions))

In grpc you should be able to use it at present.

@zewelor
Copy link
Author

zewelor commented Jun 17, 2020

Thanks I will look into it.

@ukclivecox
Copy link
Contributor

Will close this assuming using Tensoflow protocol is the best solution as suggested. Please reopen if still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs to be triaged and prioritised accordingly
Projects
None yet
Development

No branches or pull requests

2 participants