Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set executor port from model deployment file #1974

Closed
chengcheng-pei opened this issue Jun 18, 2020 · 2 comments
Closed

Set executor port from model deployment file #1974

chengcheng-pei opened this issue Jun 18, 2020 · 2 comments
Labels
triage Needs to be triaged and prioritised accordingly

Comments

@chengcheng-pei
Copy link
Contributor

now, the executor port is determined by ENV variable in seldon-core-operator and default port:

func getExecutorHttpPort() (engine_http_port int, err error) {

But, we need the flexibility to set the executor port from model deployment resource file.
e.g. when deploying xgboost, we set port to 5001. when deploying tf, we set port to 8000.

Otherwise, we need update service too. for executor, the service exposes 8000 for rest and 5001 for grpc, which is good enough.

@chengcheng-pei chengcheng-pei added the triage Needs to be triaged and prioritised accordingly label Jun 18, 2020
@ukclivecox
Copy link
Contributor

The executor runs on a single port. This is separate from any model port for http or grpc which can be defined in the graph section of the spec. Not sure this is required. Please reopen if use case is more specific.

@chengcheng-pei
Copy link
Contributor Author

now, the only place to define the executor port is in seldon-core-operator env.

it is not very flexible to use. we still try to use 5001 as grpc port, and 8000 for rest.
but after seldon-core installed, we cannot use two ports for grpc and rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs to be triaged and prioritised accordingly
Projects
None yet
Development

No branches or pull requests

2 participants