Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seldon Core operator Crashes when deployment with empty predictor is passed #2020

Closed
axsaucedo opened this issue Jun 27, 2020 · 1 comment · Fixed by #2314
Closed

Seldon Core operator Crashes when deployment with empty predictor is passed #2020

axsaucedo opened this issue Jun 27, 2020 · 1 comment · Fixed by #2314
Assignees
Labels
Milestone

Comments

@axsaucedo
Copy link
Contributor

Describe the bug

When creating a seldon deployment with empty predictors, the operator enters crash loop.

To reproduce

kubectl apply -f - << END
apiVersion: machinelearning.seldon.io/v1
kind: SeldonDeployment
metadata:
  name: sklearn
spec:
  name: iris
  predictors: []
END

Expected behaviour

The webhook should reject the deployment / patch.

Environment

  • Kubernetes Version: 1.16
  • Cloud Provider: Docker Desktop
  • Deployed Seldon System Images:
          value: docker.io/seldonio/engine:1.2.0
          value: docker.io/seldonio/seldon-core-executor:1.2.0
        image: docker.io/seldonio/seldon-core-operator:1.2.0
@axsaucedo axsaucedo added bug triage Needs to be triaged and prioritised accordingly labels Jun 27, 2020
@ukclivecox ukclivecox added this to the 1.2 milestone Jun 27, 2020
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Jul 9, 2020
@ukclivecox ukclivecox modified the milestones: 1.2, 1.3 Jul 9, 2020
@ukclivecox ukclivecox self-assigned this Aug 20, 2020
@ukclivecox
Copy link
Contributor

Can be fixed along with #2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants