Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request logger retries #2079

Closed
ryandawsonuk opened this issue Jul 6, 2020 · 1 comment
Closed

request logger retries #2079

ryandawsonuk opened this issue Jul 6, 2020 · 1 comment
Labels
triage Needs to be triaged and prioritised accordingly

Comments

@ryandawsonuk
Copy link
Contributor

ryandawsonuk commented Jul 6, 2020

The request logger currently supports retries on conflicting inserts/updates - https://github.com/SeldonIO/seldon-core/blob/master/components/seldon-request-logger/app/default_logger.py#L133

But not for the case of a connection blip. These should be rare but I've seen them happen occasionally during a load test on openshift (using the openshift cluster logging operator's install of elastic). Did use python retry library in a previous incarnation. I don't think we want retries by default as that could lead to request numbers multiplying but it would be good to have the option to set (which we could then enable for this particular openshift setup).

@ryandawsonuk ryandawsonuk added the triage Needs to be triaged and prioritised accordingly label Jul 6, 2020
@ryandawsonuk
Copy link
Contributor Author

ryandawsonuk commented Jul 6, 2020

Actually just tried this again and it was fine. I may have been getting confused before by Unverified HTTPS request warnings. Don't think we need this after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs to be triaged and prioritised accordingly
Projects
None yet
Development

No branches or pull requests

1 participant