Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLFlowServer predict function ignores feature_names parameter #2113

Closed
meoril opened this issue Jul 13, 2020 · 0 comments · Fixed by #2135
Closed

MLFlowServer predict function ignores feature_names parameter #2113

meoril opened this issue Jul 13, 2020 · 0 comments · Fixed by #2135
Labels
Milestone

Comments

@meoril
Copy link
Contributor

meoril commented Jul 13, 2020

Describe the bug

In MLFlowServer.py, the SeldonComponent's predict function implementation seems to ignore the feature_names parameter, and sends the MLFlow pyfunc predict function a wrong type.
MLFlow's predict function expects DataFrame instance, and the MLFlowServer sends numpy.ndarray instance instead, which causes unexpected behaviours (can't call the columns property of the DataFrame interface).

To reproduce

Serve a simple MLFlow model that needs to access the DataFrame's columns property.
Call the predictions API for your served model with the names and ndarray properties filled with sample data.
Or just look at the MLFlowServer predict function.

Expected behaviour

The registered MLFlow model should receive the X param as a pandas.DataFrame and not as a numpy.ndarray.

Thanks

@meoril meoril added bug triage Needs to be triaged and prioritised accordingly labels Jul 13, 2020
@axsaucedo axsaucedo added this to the 1.3 milestone Jul 15, 2020
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants