Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of mapping type from request logger #3013

Closed
SachinVarghese opened this issue Mar 4, 2021 · 2 comments · Fixed by #3014
Closed

Removal of mapping type from request logger #3013

SachinVarghese opened this issue Mar 4, 2021 · 2 comments · Fixed by #3014
Assignees

Comments

@SachinVarghese
Copy link
Contributor

SachinVarghese commented Mar 4, 2021

This issue pertains to the removal of mapping types in new elastic versions, as mentioned here.

So we will need to deprecate the inferencerequest mapping type in the current request logger implementation in favour of a unique _doc type. Source Link

@SachinVarghese SachinVarghese added enhancement triage Needs to be triaged and prioritised accordingly labels Mar 4, 2021
@SachinVarghese SachinVarghese self-assigned this Mar 4, 2021
@SachinVarghese SachinVarghese removed the triage Needs to be triaged and prioritised accordingly label Mar 4, 2021
@ukclivecox ukclivecox modified the milestone: 1.7 Mar 4, 2021
@SachinVarghese
Copy link
Contributor Author

SachinVarghese commented Mar 4, 2021

Not an extremely urgent requirement, since the current request logger implementation would fail only for elastic versions above 8.0 as per https://www.elastic.co/guide/en/elasticsearch/reference/current/removal-of-types.html#_schedule_for_removal_of_mapping_types

@SachinVarghese
Copy link
Contributor Author

So just for clarity,

How we update elastic indexes before version 8.0

PUT <index-name>/inferencerequest/<request-id>
{
  "<data-key>": "<data-value>",
}

How we update elastic indexes now post version 8.0

PUT <index-name>/_doc/<request-id>
{
  "<data-key>": "<data-value>",
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants