Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong required variable in documentation #3097

Closed
PranY opened this issue Mar 27, 2021 · 1 comment
Closed

Wrong required variable in documentation #3097

PranY opened this issue Mar 27, 2021 · 1 comment
Labels

Comments

@PranY
Copy link

PranY commented Mar 27, 2021

Describe the bug

I was trying to run seldon-core packaged server and after wasting too much time providing the credentials mentioned at https://github.com/SeldonIO/seldon-core/blob/v1.1.0/doc/source/servers/overview.md , I was forced to read the storage.py documentation. There I found that AWS_ENDPOINT_URL isn't a required parameter 'S3_ENDPOINT' is. Please change the documentation or the code.

To reproduce

Run any custom seldon-core model using
https://github.com/SeldonIO/seldon-core/blob/v1.1.0/doc/source/servers/overview.md

Expected behaviour

the deployment should work

Environment

  • Cloud Provider: minikube
  • Kubernetes Cluster Version: Major:"1", Minor:"20", GitVersion:"v1.20.5", GitCommit:"6b1d87acf3c8253c123756b9e61dac642678305f", GitTreeState:"clean", BuildDate:"2021-03-18T01:10:43Z", GoVersion:"go1.15.8", Compiler:"gc", Platform:"linux/amd64"
@PranY PranY added bug triage Needs to be triaged and prioritised accordingly labels Mar 27, 2021
@axsaucedo axsaucedo removed the triage Needs to be triaged and prioritised accordingly label Apr 1, 2021
@axsaucedo
Copy link
Contributor

Thanks for opening the issue. Latest seldon core now uses a latter version of kfserving which renamed the variable, so the documentation for this version reflects this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants