Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set GUNICORN_THREADS to 1 by default #3332

Closed
axsaucedo opened this issue Jun 26, 2021 · 0 comments · Fixed by #3346
Closed

Set GUNICORN_THREADS to 1 by default #3332

axsaucedo opened this issue Jun 26, 2021 · 0 comments · Fixed by #3346
Labels
triage Needs to be triaged and prioritised accordingly

Comments

@axsaucedo
Copy link
Contributor

As part of #2656 one of the identified improvements is to set the GUNICORN_THREADS to 1 by default. This is primarily because most processing with seldon core will be CPU intensive, and hence GUNICORN_WORKERS will be the main configurable parmeter. Furthermore, if threads are set to > 1, it can result in perceived added latency from work sitting idle blocked due to the Python GIL limitations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage Needs to be triaged and prioritised accordingly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated default rest threads to 1 and added grpc threads axsaucedo/seldon-core
1 participant
@axsaucedo