Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Helm Chart improvements: priorityClassName #3974

Closed
pierluigilenoci opened this issue Mar 9, 2022 · 1 comment · Fixed by #4030
Closed

[FR] Helm Chart improvements: priorityClassName #3974

pierluigilenoci opened this issue Mar 9, 2022 · 1 comment · Fixed by #4030
Assignees
@ukclivecox

Comments

@pierluigilenoci
Copy link

It would be very helpful to have the ability to define priorityClassName for the deployments of seldon-controller-manager when installed with the chart.

Judging by the template, this is currently not possible: https://github.com/SeldonIO/seldon-core/blob/master/helm-charts/seldon-core-operator/templates/deployment_seldon-controller-manager.yaml

Ref:
@ukclivecox ukclivecox self-assigned this Mar 14, 2022
@ukclivecox ukclivecox mentioned this issue Apr 4, 2022
Merged
@pierluigilenoci
Copy link
Author

Thank you @cliveseldon and @axsaucedo, really appreciated it. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ukclivecox ukclivecox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow priorityClassName for manager
2 participants
@ukclivecox @pierluigilenoci