Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status can become Available even with Exception in Operator #429

Closed
ukclivecox opened this issue Feb 5, 2019 · 0 comments · Fixed by #488
Closed

Status can become Available even with Exception in Operator #429

ukclivecox opened this issue Feb 5, 2019 · 0 comments · Fixed by #488
Assignees
@ukclivecox
Labels
bug Operator
Milestone
0.2.x

Comments

@ukclivecox
Copy link
Contributor

The status update is just checking Deployment replicas but other exceptions may occur during Operator creation. Need to check that state is not "Failed" and if so don't change.

change:

seldon-core/cluster-manager/src/main/java/io/seldon/clustermanager/k8s/SeldonDeploymentStatusUpdateImpl.java

Line 123 in cbbcc6b

if (isAvailable(mlBuilder,mlDep))

To check current state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ukclivecox ukclivecox

Labels
bug Operator
Projects
None yet
Milestone
0.2.x
Development

Successfully merging a pull request may close this issue.

Updates for various Python and Operator fixes
1 participant
@ukclivecox