Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install blocked by PyYaml dependency broken with new Cython 3 #5033

Closed
lpfann opened this issue Jul 18, 2023 · 3 comments · Fixed by #5034
Closed

Install blocked by PyYaml dependency broken with new Cython 3 #5033

lpfann opened this issue Jul 18, 2023 · 3 comments · Fixed by #5034
Labels

Comments

@lpfann
Copy link
Contributor

lpfann commented Jul 18, 2023

There was a new release of Cython v3 yesterday, which breaks all versions of PyYaml<6.0.1.
This makes it impossible to install seldon-core currently.
More information here: yaml/pyyaml#724

"PyYAML >= 5.4, < 5.5",

Is it possible to relax the dependency range to this?

 "PyYAML >= 5.4, <= 6.0.1", 
@lpfann lpfann changed the title PyYaml dependency broken with new Cython3 PyYaml dependency broken with new Cython 3 Jul 18, 2023
@lpfann lpfann changed the title PyYaml dependency broken with new Cython 3 Install blocked by PyYaml dependency broken with new Cython 3 Jul 18, 2023
@dictcp
Copy link

dictcp commented Jul 19, 2023

upstream decided not to release fix for pyyaml v5.4 (see yaml/pyyaml#726 (comment))
so a pyyaml version pump in seldon is needed as a proper fix.

and it would be great if the fix (if any) can be backport to seldon-core v1.x as well.


and as workaround, per yaml/pyyaml#724 (comment)
you consider to install pyyaml via pip install "cython<3.0.0" wheel && pip install pyyaml==5.4.1 --no-build-isolation, before installing your other dependencies

@kellybean-tulcolabs
Copy link

kellybean-tulcolabs commented Jul 19, 2023

and it would be great if the fix (if any) can be backport to seldon-core v1.x as well.

➕ there are innocent models dying out here, we're pretty heavily blocked until this is resolved

and as workaround, per yaml/pyyaml#724 (comment) you consider to install pyyaml via pip install "cython<3.0.0" wheel && pip install pyyaml==5.4.1 --no-build-isolation, before installing your other dependencies

In case you have other dependencies getting in the way, it seems the reverse also works. I'm able to install pyyaml==6.0.1 and pip install --no-build-isolation seldon-core==1.15.0

@kylebluenote
Copy link

and it would be great if the fix (if any) can be backport to seldon-core v1.x as well.

➕ there are innocent models dying out here, we're pretty heavily blocked until this is resolved

and as workaround, per yaml/pyyaml#724 (comment) you consider to install pyyaml via pip install "cython<3.0.0" wheel && pip install pyyaml==5.4.1 --no-build-isolation, before installing your other dependencies

In case you have other dependencies getting in the way, it seems the reverse also works. I'm able to install pyyaml==6.0.1 and pip install --no-build-isolation seldon-core==1.15.0

Jumping in on this train here, we're blocked on this as well and upgrading doesn't look like it's going to fix things for us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants