New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine resources not configurable in new operator #598

Closed

ryandawsonuk opened this issue May 28, 2019 · 1 comment

Assignees

Contributor

ryandawsonuk commented May 28, 2019

They were previously - see

seldon-core/cluster-manager/src/main/java/io/seldon/clustermanager/k8s/SeldonDeploymentOperatorImpl.java

Line 159 in 67af7a0

if (predictorDef.hasEngineResources())

But now it seems to be hard-wired https://github.com/SeldonIO/seldon-operator/blob/cae514445ba909a39e44504a1c9e8e16b39b5bda/pkg/controller/seldondeployment/seldondeployment_controller.go#L186

Related #597

ukclivecox self-assigned this

Contributor Author

ryandawsonuk commented Jun 17, 2019

Seems they are configurable, it's only the default value that is hardwired.

ryandawsonuk closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment