Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golang CRD api #734

Closed
Koshmaar opened this issue Jul 27, 2019 · 6 comments
Closed

Golang CRD api #734

Koshmaar opened this issue Jul 27, 2019 · 6 comments

Comments

@Koshmaar
Copy link

Hi, are there any plans to create golang API for deploying models, deleting them etc. using client-gen tools? There are some resources about that:

I know about https://github.com/SeldonIO/seldon-core/tree/master/examples/wrappers/go
But it is using json which would need to be templated, while using approaches from above would allow to use golang types.

@ukclivecox
Copy link
Contributor

@Koshmaar
Copy link
Author

Koshmaar commented Jul 28, 2019

Actually it looks like exactly what I need. Question though, is it compatible with Seldon 0.2.8? I don't want to upgrade now to 0.3.0+ (which AFAIK bundled core and core-crd into operator).

@ukclivecox
Copy link
Contributor

It should be compatible as the CRD is backwards compatible between these versions. We haven't tried. Please feedback.

@Koshmaar
Copy link
Author

I am able to deploy model using seldon 0.2.8 with golang seldon operator library :) However, now the deployment is bundled into one ie.

my-namespace   dep-5188857-dep-5188857-d660749-74cc64bc8d-cnsjp          2/2     Running             0          37s

which has two containers with classifier and seldon-container-engine. While before deployment consisted of two pods -classifier and -svc-orch , ie.

dep-2511961-dep-2511961-classifier-0-64997cd757-9kmmr
dep-2511961-dep-2511961-svc-orch-58cf4d4bdd-5m7qk

Is it something that has been changed in 0.3.0? Or perhaps its caused by deploying model in custom namespace (instead of default)? Also, is there a way to control it (bring back old structure)?

@ukclivecox
Copy link
Contributor

Yes the engine svc-orch will be packaged by default in your first podSpec. If you want the old behaviour you can control this with the annotation seldon.io/engine-separate-pod

See https://docs.seldon.io/projects/seldon-core/en/latest/graph/annotations.html#service-orchestrator

@Koshmaar
Copy link
Author

Koshmaar commented Aug 7, 2019

Thanks :)

@Koshmaar Koshmaar closed this as completed Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants