Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure JSON format is not modified for ALL the REST APIs (only implemented for /predict) #739

Closed
axsaucedo opened this issue Aug 1, 2019 · 0 comments · Fixed by #847
Closed

Ensure JSON format is not modified for ALL the REST APIs (only implemented for /predict) #739

axsaucedo opened this issue Aug 1, 2019 · 0 comments · Fixed by #847
Assignees
@axsaucedo
Milestone
1.0

Comments

@axsaucedo
Copy link
Contributor

When a REST request gets parsed into a Proto, all the integers get converted to floats, which ends up changing the requests. This was fixed for the /predict endpoint in #707. This needs to be done for the rest of the APIs beyond just the /predict API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axsaucedo axsaucedo

Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Standardisation of rest apis axsaucedo/seldon-core
2 participants
@axsaucedo @ukclivecox