Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javaopts -Xmx throws error #784

Closed
OrBarda opened this issue Aug 12, 2019 · 1 comment
Closed

javaopts -Xmx throws error #784

OrBarda opened this issue Aug 12, 2019 · 1 comment
Milestone

Comments

@OrBarda
Copy link

OrBarda commented Aug 12, 2019

Hi,
javaopts has something wrong, when I'm trying to set seldon.io/engine-java-opts: "-Xmx2G" I get the following:
image
Here's the deployment file:
image

@ukclivecox ukclivecox added this to the 1.0.x milestone Aug 24, 2019
@ukclivecox
Copy link
Contributor

This is a limitation of annotations it seems in apps.Deployment checks. The current operator allows those to be specified at the top level but we may need to rethink this. See https://docs.seldon.io/projects/seldon-core/en/latest/graph/annotations.html#service-orchestrator

Longer term we will move to a Go executor to replace the Java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants