Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to override seldon prediction service's service name #949

Closed
ai-athena-oracle opened this issue Oct 14, 2019 · 0 comments
Closed

Comments

@ai-athena-oracle
Copy link

Currently, the seldon service's name is comprised of several components according to the manifest, see https://github.com/SeldonIO/seldon-operator/blob/89e3b5ee3d78bf7e1dacfffbfcaff2ba873b7d6a/pkg/apis/machinelearning/v1alpha2/seldondeployment_types.go#L117, and the name will be hashed first if the length exceeds 63. The reason for combining the serval components, as @cliveseldon explained, is to make sure there is no clash of service names for complex graphs.

Given there could be further changes in the above function, the actual service name would become unpredictable. Especially, in some situations, one needs to know the service's name in order to be able to know where exactly to curl the prediction service even before the service is deployed.

@cliveseldon suggests to add a feature so that the prediction service's service name can be overridden by the user, and then it is the user's responsibility to make sure the services don't clash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant