Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix helm version in Chart.yaml #961

Closed
ukclivecox opened this issue Oct 17, 2019 · 1 comment
Closed

Fix helm version in Chart.yaml #961

ukclivecox opened this issue Oct 17, 2019 · 1 comment
Assignees
@gsunner
Milestone
1.0

Comments

@ukclivecox
Copy link
Contributor

We should be using appVersion.
Leave version
@ukclivecox ukclivecox added this to the 0.5.x milestone Oct 17, 2019
@ukclivecox ukclivecox modified the milestones: 0.5.x, 1.0.x Oct 24, 2019
@gsunner
Copy link
Contributor

gsunner commented Nov 12, 2019

Looking at the helm docs
version: A SemVer 2 version (required)
appVersion: The version of the app that this contains (optional). This needn't be SemVer.

So looks like version is required and its what we use, appVersion not necessary.

@gsunner gsunner closed this as completed Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsunner gsunner

Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@gsunner @ukclivecox