fix failures

Author: titusfortner

rb/lib/selenium/webdriver/remote/http/default.rb

@@ -32,11 +32,11 @@ class Default < Common
           # Debuggers that freeze the process will not be able to evaluate any operations if that happens.
           # @param [Numeric] open_timeout - Open timeout to apply to HTTP client.
           # @param [Numeric] read_timeout - Read timeout (seconds) to apply to HTTP client.
-          def initialize(open_timeout: nil, read_timeout: nil, socket_timeout: 30, socket_interval: 0.1)
+          def initialize(open_timeout: nil, read_timeout: nil, socket_timeout: nil, socket_interval: nil)
             @open_timeout = open_timeout
             @read_timeout = read_timeout
-            @socket_timeout = socket_timeout
-            @socket_interval = socket_interval
+            @socket_timeout = socket_timeout || 30
+            @socket_interval = socket_interval || 0.1
             super()
           end
 

rb/sig/lib/selenium/webdriver/remote/http/common.rbs

@@ -17,7 +17,7 @@ module Selenium
 
           def self.user_agent: -> String
 
-          attr_writer server_url: String
+          attr_writer server_url: URI::Generic
 
           def quit_errors: () -> Array[untyped]
 

rb/sig/lib/selenium/webdriver/remote/http/default.rbs

@@ -20,9 +20,9 @@ module Selenium
 
           attr_accessor socket_timeout: int
 
-          attr_accessor socket_interval: float
+          attr_accessor socket_interval: Numeric
 
-          def initialize: (?open_timeout: untyped?, ?read_timeout: untyped?) -> void
+          def initialize: (?open_timeout: untyped?, ?read_timeout: untyped?, ?socket_timeout: int?, ?socket_interval: Numeric?) -> void
 
           def close: () -> untyped
 

rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb

@@ -169,17 +169,14 @@ def root
           @root ||= Pathname.new('../../../../../../../').realpath(__FILE__)
         end
 
-        def create_driver!(listener: nil, **opts, &block)
+        def create_driver!(listener: nil, **, &block)
           check_for_previous_error
 
-          socket_timeout = opts.delete(:socket_timeout)
-          http_client = WebDriver::Remote::Http::Default.new(socket_timeout: socket_timeout) if socket_timeout
-
           method = :"#{driver}_driver"
           instance = if private_methods.include?(method)
-                       send(method, listener: listener, http_client: http_client, options: build_options(**opts))
+                       send(method, listener: listener, options: build_options(**))
                      else
-                       WebDriver::Driver.for(driver, listener: listener, options: build_options(**opts))
+                       WebDriver::Driver.for(driver, listener: listener, options: build_options(**))
                      end
           @create_driver_error_count -= 1 unless @create_driver_error_count.zero?
           if block

rb/spec/unit/selenium/webdriver/remote/http/default_spec.rb

@@ -36,8 +36,6 @@ module Http
 
             expect(http.open_timeout).to eq 60
             expect(http.read_timeout).to eq 60
-            expect(http.socket_timeout).to eq 30
-            expect(http.socket_interval).to eq 0.1
           end
 
           describe '#initialize' do
@@ -50,7 +48,6 @@ module Http
               expect(client.read_timeout).to eq 22
               expect(client.socket_timeout).to eq 4
               expect(client.socket_interval).to eq 0.5
-
             end
           end