Skip to content

Commit 4023c01

Browse files
Earlopaindiemol
andauthored
[rb] Remove prism dependency (#16437)
* [rb] Remove `prism` dependency This project does not use prism at all. At most it is being used by rubocop during local development. It was added in #16357 but it is unclear to me why. I just bumped it for this repo, perhaps that JRuby issue has since been fixed. Either way, it should not be part of the gemspec. * Pin prism to 1.4.0 for the project It fails to build with the following error: src/prism.c: In function ‘context_terminator’: src/prism.c:8651:62: error: conversion to ‘unsigned int’ from ‘int’ may change the sign of the result [-Werror=sign-conversion] 8651 | return token->type < 32 && (context_terminators[context] & (1 << token->type)); | ^ cc1: all warnings being treated as errors --------- Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
1 parent b308fbf commit 4023c01

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

rb/Gemfile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,7 @@ gem 'activesupport', '~> 7.0', require: false, platforms: %i[mri mingw x64_mingw
1010
gem 'curb', '~> 1.0.5', require: false, platforms: %i[mri mingw x64_mingw]
1111
gem 'debug', '~> 1.7', require: false, platforms: %i[mri mingw x64_mingw]
1212
gem 'steep', '~> 1.5.0', require: false, platforms: %i[mri mingw x64_mingw]
13+
14+
# Prism staring with 1.5 fails to build with the following error:
15+
# src/prism.c:8651:62: error: conversion to ‘unsigned int’ from ‘int’ may change the sign of the result [-Werror=sign-conversion]
16+
gem 'prism', ['~> 1.0', '< 1.5']

rb/Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ PATH
77
base64 (~> 0.2)
88
json (<= 2.13.2)
99
logger (~> 1.4)
10-
prism (~> 1.0, < 1.5)
1110
rexml (~> 3.2, >= 3.2.5)
1211
rubyzip (>= 1.2.2, < 4.0)
1312
websocket (~> 1.0)
@@ -201,6 +200,7 @@ DEPENDENCIES
201200
curb (~> 1.0.5)
202201
debug (~> 1.7)
203202
git (~> 1.19)
203+
prism (~> 1.0, < 1.5)
204204
rack (~> 2.0)
205205
rake (~> 13.0)
206206
rspec (~> 3.0)

rb/selenium-webdriver.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ Gem::Specification.new do |s|
5252
s.add_dependency 'base64', ['~> 0.2']
5353
s.add_dependency 'json', ['<= 2.13.2']
5454
s.add_dependency 'logger', ['~> 1.4']
55-
s.add_dependency 'prism', ['~> 1.0', '< 1.5']
5655
s.add_dependency 'rexml', ['~> 3.2', '>= 3.2.5']
5756
s.add_dependency 'rubyzip', ['>= 1.2.2', '< 4.0']
5857
s.add_dependency 'websocket', ['~> 1.0']

0 commit comments

Comments
 (0)