-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐛 Bug]: significant performance and memory usage - regressions when switching from Selenium 3 to 4 #10113
Comments
@christophs78, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
Maybe this issue is somehow related to parallelism / concurrency. |
I think this is related to #9359 A workaround is also provided in the issue |
Played around with this for one and a half hour. Yes it´s the same issue, but the workaround does not work. Ah. It depends on the Java-version. The work-around does not work for Java 8, but it works for Java 11. IMO #9359 needs to be reopened. |
Well, looks like everyone now has to use Java 11. I'm dismayed to be able to duplicate your findings. I'll close this one and re-open that one. :-/ |
@christophs78 Thank you for your findings and effort in solving this! I am sorry the earlier fix was not the perfect fix for this problem.
It was made since
Based on your findings, what do you think is primarily causing the problem? Any suggestions on how we can tackle it? Thank you! |
@pujagani Thank´s for your reply. To be honest i currently have no good idea how to fix this within Selenium. |
@christophs78 thanks again for your help with tracking this down. Fwiw, JetBrains Toolbox makes it really simple to downgrade a minor version to something that supports Bazel. Also, if you can join us on the Selenium chat (IRC or Slack)— https://www.selenium.dev/support/#ChatRoom |
Thanks for offering your collaboration. I´ll come back as soon as i have good questions to ask. My efforts to reproduce this issue with a sandbox plain-java-project have not been successful yet. At least i understand some previous conversation regarding So i tested https://github.com/titusfortner/bug9359 with each Java-version starting with 13. It work´s up to Java 16 and is broken with Java 17. (I´ll keep Java 8 aside for now. With Java 17 it is broken for Hotspot and J9.) |
Changes within openjdk/jdk@5b7b18c#diff-85448900741ca0f6d70b61cb62d38bbbd49b015f78c4efa67ea8cdc3ae15e9f4 and openjdk/jdk@5cfa8c9#diff-e398beb49cd8d3e6c2f3a8ca8eee97172c57d7f88f3ccd8a3c704632cab32f5f did some sgnificant changes to Any thought´s about this? Maybe it´s a regression in Java 17. Would help to have a plain Java reproducer for this. If we are able to reproduce this with plain Java we may reach out to the OpenJDK-team. |
Side-note regarding Java 8: ForkJoinPool does not have a constructor to define things like maxPoolSize. This enhanced constructor was introduced with Java 9. - - > We propably can't fix this issue for Java 8. |
Java 17 - issue - reproducer: https://github.com/christophs78/ForkJoinPoolReproducer |
Hi, I'm not really sure if it does solve the selenium problem, but it does solve the reproducer test in JDK11 and 17... |
Since we're discussing it here, I'll leave it open, and close the other one. :) |
Do I have this right? Java 8 isn't going to work; need to stick with JUnit 4 or Selenium 3. All in all this isn't as bad as I feared. The Java 8 thing sucks, but I think there are more 9-16 folks than 17 folks still. |
Excellent point! I´m able to confirm this fixes the issue. Did following within
So i'll try to do a proper JUnit 5 PR. |
There´s already junit-team/junit5#2787 and junit-team/junit5#2792 covering this. -> We just have to wait for JUnit 5.9. |
Thank you @christophs78 for digging into this so well. Appreciate the efforts :) |
Hello @christophs78 Do we have any workaround for Java 17 or need to wait for Junit 5.9? |
No good workaround. Disabling ParallelExecution, using Java 11 instead of 17.... |
@christophs78 I noticed for Java 17, if we keep getMinimumRunnable as 0 in the Custom Strategy it works fine and there is no issue. Can you please check once? @OverRide
|
@tkumar18 : Excellent point! I´m able to confirm this helps. |
@christophs78 Thanks for the confirmation. Will still need to wait for 5.9 though. |
@tkumar18 @christophs78 can you please confirm if this issue resolved, what is the work around for now. |
@christophs78 what will change with JUnit 5.9? And thanks again for your work on this. |
Since @tkumar18 figured out returning 0 for |
Excellent. I'll close this issue then if we're not expecting any additional functionality. Thanks everyone for your assistance getting this sorted. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What happened?
PrimeFaces comes with a suite of integrationstest: https://github.com/primefaces/primefaces/tree/master/primefaces-integration-tests
We currently use Selenium 3.141.59. When i run them on my dev-machine (8C/16T, 32 GB RAM) it looks like this:
With primefaces/primefaces#8145 we try to upgrade to Selenium 4.1.0. There it looks like this:
Additional my notebook get´s unresponsive.
We also run this integrationtests on Github actions. They take about twice the time with Selenium 4.1.0. (And we run into some follow-up problems probably because of worse performance due to resource starvation.)
There already has been a (to some degree) similar issue: #9536
How can we reproduce the issue?
See PrimeFaces-Github-links above.
Relevant log output
Selenium 4.1.0:
https://github.com/primefaces/primefaces/actions/runs/1539682360
Compare this with a run on 3.141.59:
https://github.com/primefaces/primefaces/runs/4413396941?check_suite_focus=true
Operating System
Windows 10, Ubuntu 20.04.3
Selenium version
Java 4.1.0
What are the browser(s) and version(s) where you see this issue?
Chrome 96.0.4664.45, Firefox 94.0.2
What are the browser driver(s) and version(s) where you see this issue?
ChromeDriver 96.0.4664.45, GeckoDriver 0.30.0
Are you using Selenium Grid?
No
The text was updated successfully, but these errors were encountered: