Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: selenium manager allows customization DRIVER_URL #12388

Closed
dongfangtianyu opened this issue Jul 20, 2023 · 12 comments
Closed

[🚀 Feature]: selenium manager allows customization DRIVER_URL #12388

dongfangtianyu opened this issue Jul 20, 2023 · 12 comments
Labels
I-question Applied to questions. Issues should be closed and send the user to community resources.

Comments

@dongfangtianyu
Copy link

Feature and motivation

Selenium Manager is very cool and provides a unified way to obtain drivers.
However, it currently does not allow users to obtain drivers from custom servers, which means it must work in an interconnected internet environment.

Although Selenium Manager supports proxies, the use of HTTPS protocol in the URL makes the mirror server unable to function.

Usage example

If DRIVER_URL allows customization through command line parameters or environment variables, then I can start an HTTP server and search for the corresponding driver in the mirror based on the URL.

The working method of Selenium Manager will not change, but it provides great help for users in isolated networks or networks that cannot access Google and GitHub

@github-actions
Copy link

@dongfangtianyu, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@MILADZASH

This comment was marked as off-topic.

@titusfortner
Copy link
Member

titusfortner commented Jul 20, 2023

@dongfangtianyu can you give logs of what you are doing and what isn't working? https://www.selenium.dev/documentation/webdriver/troubleshooting/logging/

@titusfortner
Copy link
Member

Or grab the current version from here https://github.com/SeleniumHQ/selenium/tree/trunk/common/manager/
And execute what you want to work that doesn't with --debug?

@titusfortner
Copy link
Member

@MILADZASH that looks like a completely separate issue, please make sure you have Firefox downloaded on your system and create a new issue rather than continuing here.

@SeleniumHQ SeleniumHQ deleted a comment from MILADZASH Jul 20, 2023
@SeleniumHQ SeleniumHQ deleted a comment from MILADZASH Jul 20, 2023
@diemol
Copy link
Member

diemol commented Jul 25, 2023

This is already possible https://www.selenium.dev/documentation/selenium_manager/ SE_DRIVER_MIRROR

@diemol diemol added I-question Applied to questions. Issues should be closed and send the user to community resources. and removed I-enhancement needs-triaging labels Jul 25, 2023
@github-actions
Copy link

💬 Please ask questions at:

@dongfangtianyu
Copy link
Author

This is already possible https://www.selenium.dev/documentation/selenium_manager/ SE_DRIVER_MIRROR

@diemol thank you, this looks exactly what I'm looking for.

But it is currently not working properly, still downloading from the original HTTPS connection.

Debug info

C:\Users\tianyu\Desktop>set | findstr SE_DRIVER_MIRROR                                                            
SE_DRIVER_MIRROR=http://127.0.0.1:8888

C:\Users\tianyu\Desktop>selenium-manager.exe --browser firefox --debug
DEBUG   Using shell command to find out firefox version
DEBUG   Running command: "set PFILES=%PROGRAMFILES: (x86)=%&& wmic datafile where name='!PFILES:\\=\\\\!\\\\Mozilla Firefox\\\\firefox.exe' get Version /value"
DEBUG   Output: "\r\r\n\r\r\nVersion=95.0.2.8022\r\r\n\r\r\n\r\r\n\r"
DEBUG   The version of firefox is 95.0.2.8022
DEBUG   Detected browser: firefox 95
ERROR   error sending request for url (https://github.com/mozilla/geckodriver/releases/latest): error trying to connect: tcp connect error:  (os error 10060)

Version info

C:\Users\Tianyu\Desktop>pip show selenium
Name: selenium
Version: 4.10.0
Summary:
Home-page: https://www.selenium.dev
Author:
Author-email:
License: Apache 2.0
Requires: certifi, trio, trio-websocket, urllib3

C:\Users\Tianyu\Desktop>selenium-manager.exe -V
selenium-manager 1.0.0-M3

Is my usage incorrect?
Kindly request experienced individuals to share more information. Thank you.

@titusfortner
Copy link
Member

@bonigarcia can you check on this?

@titusfortner titusfortner reopened this Jul 30, 2023
@bonigarcia
Copy link
Member

That feature is planned, but it is not yet available on the Rust side:

#11687

SE_DRIVER_MIRROR should not be in the documentation yet. I want to enhance the documentation page of Selenium Manager by next month.

@titusfortner
Copy link
Member

Thanks. I've removed it from the docs, and we'll track this issue there.

Copy link

github-actions bot commented Dec 9, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I-question Applied to questions. Issues should be closed and send the user to community resources.
Projects
None yet
Development

No branches or pull requests

5 participants