Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Automatically drain node after n-failed session attempts #13865

Closed
krishtoautomate opened this issue Apr 24, 2024 · 8 comments
Closed

Comments

@krishtoautomate
Copy link

Feature and motivation

User might have n number of nodes and if sessions are randomly allocated during the tests and are failing on few nodes due to issue with docker node. It will be great if this feature is implemented: Automatically drain node after n-failed session attempts.

Usage example

when new RemoteWebDriver session is creating on n-number of nodes with 100-200 test cases in parallel, if I have issues with any docker nodes, those nodes will drain automatically after n(5-10) failed session attempts. the total impact on test execution is less and I end up re-executing only few tests which failed initially.

Copy link

@krishtoautomate, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@diemol
Copy link
Member

diemol commented Apr 24, 2024

Why is the Docker node failing? How are you monitoring that? Can you share more details? It sounds like we want to fix something with a workaround instead of a proper fix.

@krishtoautomate
Copy link
Author

Failed Reasons can be any, proxy or internet or chrome crashing or not launching due to driver mismatch. Provided as an example to explain use case. Node can be appium node as well.

@diemol
Copy link
Member

diemol commented Apr 24, 2024

But that is a Node misconfiguration. Infrastructure needs to be tested before being made available for use. Implementing something like this would hide issues. It is an incomplete workaround.

@krishtoautomate
Copy link
Author

if we have too many nodes, sometimes our nodes might fall behind for different reasons and we dont want our tests to impact due to nodes which are not working. is their any way this feature can be implemented with some cli argument to make it active and default as off

@diemol
Copy link
Member

diemol commented Apr 26, 2024

If you have too many nodes, how are you monitoring them? Why would there be a driver mismatch? Are you not testing the changes before sharing the modified infrastructure with the rest of the users?

If a Node is not working, testing the changes done to it should alert you even before you run any regular tests.

Suppose this feature request is implemented, and you have a driver mismatch or network issues with your nodes. What ends up happening is that all of them get shut down. How would you diagnose the actual problem? The result is that the infrastructure went down, and you need to figure out why.

Copy link

This issue was closed because we did not receive any additional information after 14 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
Copy link

github-actions bot commented Jun 9, 2024

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants