Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Semantic 2.4 ? #53

Open
eveevans opened this issue Jan 30, 2019 · 4 comments
Open

Update to Semantic 2.4 ? #53

eveevans opened this issue Jan 30, 2019 · 4 comments

Comments

@eveevans
Copy link

The latest version of Semantic UI is 2.4.2
And the latest version of the Gem is 2.3.1...
Why we haven't latest version ?

@brendon
Copy link
Collaborator

brendon commented Jan 31, 2019

Hi @eveevans, it's basically a roadblock. The gems that this library depends on only implement less 1.7.0 and there isn't really an easy path to upgrade beyond this as much of the support dependencies are abandoned. Semantic UI recently pulled in a requirement for Less > 3 which means we're stuck. If you have time and want to investigate and work on the dependencies issue I'd be more than thankful.

For me, I ended up switching to webpacker and pulling Semantic UI in that way (this wasn't easy either).

@eveevans
Copy link
Author

Thanks @brendon I really appreciate your response.

I was afraid of that. Where can I find a discussion about that ?
Which are the problematic dependencies ?

And thanks for the tip.

@brendon
Copy link
Collaborator

brendon commented Feb 1, 2019

Hi @eveevans, here's the Semantic UI upgrade PR:

Semantic-Org/Semantic-UI#6512

This repo depends on https://github.com/metaskills/less-rails, which depends on https://github.com/cowboyd/less.rb which depends on https://github.com/cowboyd/commonjs.rb

Here's my issue at less.rb: cowboyd/less.rb#87

Someone attempted to go to Less 2: cowboyd/less.rb#79

Hope that helps :)

@brendon
Copy link
Collaborator

brendon commented Feb 1, 2019

My gut feeling about this would be to abandon all this ruby based less stuff and just parse the whole thing with less.js instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants