Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Menu.Item fitted="vertically"> doesn't work #1453

Closed
tashburn opened this issue Mar 14, 2017 · 6 comments
Closed

<Menu.Item fitted="vertically"> doesn't work #1453

tashburn opened this issue Mar 14, 2017 · 6 comments
Labels

Comments

@tashburn
Copy link

<Menu.Item fitted="horizontally"> works.
<Menu.Item fitted="vertically"> does not work (to eliminate the top and bottom padding).

@levithomason
Copy link
Member

levithomason commented Mar 14, 2017

Could you post a codepen demonstrating the issue? This works in the docs:

http://react.semantic-ui.com/collections/menu#menu-example-fitted

image

@tashburn
Copy link
Author

I expect no vertical padding to do this (see picture). That's not what it does for me, or in the docs.
What's it supposed to do?

ex

@levithomason
Copy link
Member

levithomason commented Mar 14, 2017

The green shading in the image above is the padding. Note the vertical padding is removed.

This more clear in a vertical menu:

image

A .ui.menu has a min-height: 2.85714286em; so the height does not collapse by default.

@tashburn
Copy link
Author

I see. Thanks.

@levithomason
Copy link
Member

❤️ I've added #1468 which adds a vertical menu for clarity:

image

@tashburn
Copy link
Author

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants