Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion : change Button.Or text for i18n #1461

Closed
Tilican opened this issue Mar 14, 2017 · 3 comments
Closed

Suggestion : change Button.Or text for i18n #1461

Tilican opened this issue Mar 14, 2017 · 3 comments

Comments

@Tilican
Copy link

Tilican commented Mar 14, 2017

Hi,

Can you add a props in Button.Or to change text ?
And set basic text to "or" ?

Have fun

@levithomason
Copy link
Member

levithomason commented Mar 14, 2017

Thanks for the suggestion. The content of the Or button is set via CSS:

image

So this change would need to happen in the CSS which is at https://github.com/Semantic-Org/Semantic-UI. The React project only includes React components.

That said, you can also simply add an override CSS rule that changes the content property as well.

@layershifter
Copy link
Member

@levithomason You're not right there, it can be done with data-text:

<div class="ui buttons">
  <button class="ui button">un</button>
  <div class="or" data-text="ou"></div>
  <button class="ui positive button">deux</button>
</div>

I think we need this functionality via text prop.

@levithomason
Copy link
Member

Thanks for the catch @layershifter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants