Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: Should work with keys instead of values #1634

Closed
karlludwigweise opened this issue Apr 26, 2017 · 1 comment
Closed

Dropdown: Should work with keys instead of values #1634

karlludwigweise opened this issue Apr 26, 2017 · 1 comment

Comments

@karlludwigweise
Copy link

The Dropdown component is working with each option's value internally. Whereas using the key, if supplied, would be correct.

Steps

Throw a set of options into a Dropdown with two identical values.

Expected Result

Show both options.

Actual Result

  1. Only the first option will be displayed.
  2. Additionally a React warning is thrown in console: "Warning: flattenChildren(...): Encountered two children with the same key..."

Version

0.68.1

Testcase

http://codepen.io/karlludwigweise/pen/xdRvYL

And yes, this is a very very awkward use-case.
@levithomason
Copy link
Member

Thanks, this is being worked on in #1639. I'll leave this open until that is merged.

@dvdzkwsk dvdzkwsk mentioned this issue Apr 28, 2017
Merged
@mcrawshaw mcrawshaw mentioned this issue May 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@levithomason @karlludwigweise