Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab.Pane's children data type needs to be updated #1798

Closed
shinstudio opened this issue Jun 25, 2017 · 1 comment
Closed

Tab.Pane's children data type needs to be updated #1798

shinstudio opened this issue Jun 25, 2017 · 1 comment
Labels

Comments

@shinstudio
Copy link

shinstudio commented Jun 25, 2017

Steps

Tab.Pane's children is supposed to be String according to PropType, but it accepts React component as well. So i think propType for children of Tab.Pane should be oneOfType([PropTypes.string, PropTypes.object]) instead of PropTypes.string

  1. <Tab.Pane>String</Tab.Pane>
  2. This should render ok.
<Tab.Pane>
     <Grid>
       <Grid.Column>Test</Grid.Column>
     </Grid>
   </Tab.Pane>
  1. Warning : Invalid prop 'children' of type 'object' supplied to 'TabPane'

Expected Result

Please check my comment above.

Actual Result

Please check my comment above.

Version

0.70.0

Testcase

Sorry I don't have the test case.

@layershifter
Copy link
Member

@shinstudio Thanks for report 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants