Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Dropdown loses the focus on the search input #1806

Closed
layershifter opened this issue Jun 29, 2017 · 7 comments
Closed

RFC: Dropdown loses the focus on the search input #1806

layershifter opened this issue Jun 29, 2017 · 7 comments

Comments

@layershifter
Copy link
Member

Extracted from #1795.

Possible I missed something, but the behaviour of our component is different from SUI's. After a click on an item SUI's dropdown still focused while our lost the focus. However, I think that it's correct and we don't need to change something there.

SUI behaviour

9fc54ec24746f0c3c35dfc04221fb941

SUIR behaviour

56dd2717a103bfe027625c8b242a3f43

@levithomason
Copy link
Member

@layershifter is this fixed in 0.72.0?

@layershifter
Copy link
Member Author

No, there was another fix.

SUI example
SUIR example

Steps

  1. Open example
  2. Click on dropdown input, it will capture focus
  3. Select a dropdown item

SUI example: will select item and keep focus
SUIR example: will select item and lose focus


In fact, we need to make a decision what behaviour is correct.

@stale
Copy link

stale bot commented Feb 4, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 4, 2018
@stale stale bot closed this as completed Mar 6, 2018
@sahilfullstack
Copy link

can I implement SUI behavior in SUIR example

@sahilfullstack
Copy link

1 similar comment
@sahilfullstack
Copy link

@layershifter
Copy link
Member Author

Don't spam please. If you have a solution, feel free to contribute and open PR.

@layershifter layershifter pinned this issue Dec 24, 2018
@layershifter layershifter unpinned this issue Dec 24, 2018
@Semantic-Org Semantic-Org locked as off-topic and limited conversation to collaborators Dec 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants