Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE: TextArea: wrong autoHeight counting #1925

Closed
slunecniborecek opened this issue Aug 3, 2017 · 3 comments
Closed

IE: TextArea: wrong autoHeight counting #1925

slunecniborecek opened this issue Aug 3, 2017 · 3 comments
Labels

Comments

@slunecniborecek
Copy link
Contributor

Based on #1843 which was closed. Unfortunately the very last commit contains an issue in IE browsers

steps 1:
copy a long text
paste using context menu

steps 2:
make text area to grow some height
select all text in it
using context menu, click 'delete' or 'cut'

Expected:
textarea is resized properly in both steps1 and steps2

Actual:
the height is not changed

@slunecniborecek
Copy link
Contributor Author

@levithomason ^

@levithomason
Copy link
Member

Thanks for the follow-up. Looks like we'll need to use the onInput method for IE. When this is done, we'll need to also update the callback signature to follow our conventions. See the onChange propType description and handler for that pattern.

@nickpedersen
Copy link
Contributor

Could I help out with this one? I can prepare a PR right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants