-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Support Popup close onClick when hoverable #2034
Comments
This would be a new Portal prop. I suggest: <Portal closeOnPortalClick /> It should default to <Popup closeOnClickInside /> How does this sound? |
Yup, sounds great. There may be cases where such an effect would be undesirable when it generally is desirable. Maybe exposing a Just thinkin out loud :) |
in retrospect, i could always just |
Per the PR, a controlled component pattern solves the issue. Set |
Steps
Popup
withhoverable
Expected Result
Popup
, call first myonClick
handler, then propagate event to internalPopup
code, which closes thePopup
Actual Result
hoverable
Popup, Popup remains visible. To close it, I have to manually manage some state to not render Popup childernVersion
0.72.0
Testcase
https://codepen.io/cdaringe/pen/RZvwdp
The text was updated successfully, but these errors were encountered: