Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several warnings on Attached Layout #2154

Closed
arimourao opened this issue Oct 2, 2017 · 3 comments · Fixed by #2197
Closed

Several warnings on Attached Layout #2154

arimourao opened this issue Oct 2, 2017 · 3 comments · Fixed by #2197
Labels

Comments

@arimourao
Copy link

I just installed semantic-ui-react to do some tests and maybe implement in an ongoing project. Right off the bat I get plenty of warnings just copying and pasting the sample code given in "attached content" layout section. It seems to work ok, but here are some of the warnings:

Warning: Failed prop type: Invalid prop attachedsupplied toMessage.

Warning: Unknown prop verticalAllign on <table> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop

Warning: validateDOMNesting(...): <th> cannot appear as a child of <thead>. See AdminPanel > TableHeader > thead > TableHeaderCell > TableCell > th.

Warning: Unknown prop verticalAllign on <table> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop

@layershifter
Copy link
Member

Please fill our issue template.

@levithomason
Copy link
Member

We've misspelled verticalAllign in the example. Align should not have 2 Ls. I wonder why we aren't seeing these prop warnings locally though?

@levithomason
Copy link
Member

levithomason commented Oct 10, 2017

We also have <Message attached='top' /> in the example, but the prop type is:

    attached: PropTypes.oneOfType([
      PropTypes.bool,
      PropTypes.oneOf(['bottom']),
    ]),

We should arguably accept top as a valid value for symmetry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants