Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: <button with-conformation="text-to-type"/> #2272

Closed
chrismatheson opened this issue Oct 31, 2017 · 2 comments
Closed

RFC: <button with-conformation="text-to-type"/> #2272

chrismatheson opened this issue Oct 31, 2017 · 2 comments

Comments

@chrismatheson
Copy link

delete with confirmation example

Im currently in the process of creating this component for my own needs and was wondering if its something that would be useful / welcome as part of semantic UI ?

obviously its still in development and needs some polish but the idea would be that the onClick is only actually called if the conformation is completed correctly.

id imagine that the usage could be something along the lines of

<Button with-conformation="text-to-type">
    Click Here
 </Button>

id imagine this idea would need substantial changes etc to fit in line with the API's of the semantic UI library, which id be happy to implement as the end result is all im after personally

@levithomason
Copy link
Member

Hi @chrismatheson, thanks for taking the time to propose this idea. I think this is best left as a specialized implementation. If we get a substantial number of requests for this feature, or if this feature.

Just in case you hadn't seen it, we also have a <Confirm /> addon. This is a simplified <Modal /> for the purposes of capturing user confirmation:

https://react.semantic-ui.com/addons/confirm#confirm-example-confirm

@levithomason levithomason changed the title Feature proposal: <button with-conformation="text-to-type"/> RFC: <button with-conformation="text-to-type"/> Oct 31, 2017
@harel
Copy link

harel commented Nov 6, 2017

I like it, and think building a library of addons would be a great thing. Those unique components give an edge to the whole library. Or, as an alternative, adding a mechanism to provide external 3rd party addons (with a SUR dependency) - even if its just a doc page explaining what is required etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants