Embed: brandedUI setting seems backwards, and doesn't affect related videos

[bennettrogers]

Steps

Create a YouTube iframe embed element, and set brandedUI to false. Observe that the YouTube logo still displays.

The documentation for the embed modules says that the brandedUI setting determines "whether to show networks branded UI like title cards, or after video calls to action."

My understanding of this is that setting brandedUI to false is meant to hide the YouTube branding on the player. Looking here however, it seems like that's backwards, and setting brandedUI to true would remove the YouTube logo.

In addition, it would be nice if this prop disabled the "related videos" setting in the YouTube embed (rel=0), since it says it's also supposed to affect "after video calls to action".

Expected Result

YouTube branding (and, ideally, related videos) are disabled when setting brandedUI={false}.

Actual Result

YouTube branding is disabled when setting brandedUI={true}. Related videos are shown no matter what.

Version

0.76.0

Testcase

https://codesandbox.io/s/o10xl8qx0y

If this is in fact a bug I'd be happy to submit a PR to fix it, but I wanted to check to see if my understanding was correct first.

[layershifter]

This behaviour is cloned from SUI, in fact you need brandedUI={true}. This means that your UI will be branded and you don't need YouTube logo 😉

I think that we need to do:

• set rel to 0 when brandedUI={true}
• add an example to docs for this

PR is welcome.

[bennettrogers]

PR submitted. I'm not sure how to add a new example, since this isn't a new parameter and there are already examples that demonstrate the brandedUI parameter. I'd be happy to add whatever you think is appropriate.