Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: set selectOnNavigation to false by default in Dropdown #2369

Closed
karlludwigweise opened this issue Dec 8, 2017 · 3 comments
Closed

RFC: set selectOnNavigation to false by default in Dropdown #2369

karlludwigweise opened this issue Dec 8, 2017 · 3 comments
Labels

Comments

@karlludwigweise
Copy link

karlludwigweise commented Dec 8, 2017

This is not a bug. Rather a request to change the default behavior of the new selectOnNavigation prop on the Dropdown component and its default value true. I would expect the default to be false.

A value in a regular select has to be confirmed with RETURN as well.

On my end this caused an avalanche of back-end actions and harmful data changes on the fly. I'm pretty sure this breaks other apps as well.

@layershifter
Copy link
Member

I'm sure that we don't need to make it false by default, however @levithomason can have another opinion.

@layershifter layershifter changed the title Dropdown: selectOnNavigation default RFC: set selectOnNavigation to false by default in Dropdown Dec 10, 2017
@levithomason
Copy link
Member

Currently, it is on by default in parity with SUI's jQuery implementation. Let's leave this open a while and see what the community thinks.

My personal opinion is that it is OK as is. I think it is the responsibility of the implementation to test and handle callbacks accordingly. Very happy to be outvoted though :)

@layershifter
Copy link
Member

Closing for housekeeping, opened for discussions there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants