Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Modal): Message dismiss on modal closes modal #2429

Closed
mosheavni opened this issue Jan 13, 2018 · 2 comments
Closed

fix(Modal): Message dismiss on modal closes modal #2429

mosheavni opened this issue Jan 13, 2018 · 2 comments

Comments

@mosheavni
Copy link

Steps to Reproduce

1. Create a controlled modal with `handleOpen` and `handleClose` exactly like the example
2. Inside the modal, create a Message component that's handled by a dedicated state, and has `onDismiss` that changes the state
3. Try to dismiss the message and see that the modal closes

Expected
The Modal should not close when dismissing a Message component

Result
Described above.

Testcase
https://codepen.io/moshem/pen/ZvRNOg

@sharno
Copy link

sharno commented Jan 16, 2018

Possibly same issue of #1580
I have the same issue too. With any change of the components rendered inside the modal, the onClose is triggered

@layershifter
Copy link
Member

Yes, it's duplicate of #1580 and can be solved with published there workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants