-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal will autoclose with an opened Portal #2446
Comments
Same happening here after upgrade to 0.77.2. |
Is it related to this #2493 ? |
Yes, this sounds like it is duplicated in #2493. See workarounds there. A fix is in the works. |
I am releasing 0.78.1 right now with a proposed fix for this. Once it is live (~10 minutes), please update the codesandbox, try it, and report back. |
Confirmed worked. Forked codesandbox here: https://codesandbox.io/s/328x7n20ym. I only needed to update to the latest 0.78.1 to get the fix. Thanks for the reporting folks! |
@levithomason it works for me too. Thank you for your work! |
@levithomason seems like the issue is reproduced when the content of modal is changed. https://codesandbox.io/s/30n2v379r1 here is the example when changing one form with another - |
if you ask, we can create a separate issue |
OK, opened #2888 |
Steps
<Modal />
with anonClose
prop and a<Portal />
.<Portal />
.<Modal />
.Expected Result
Modal should open.
Actual Result
Modal never will open. Modal uses Portal as a wrapper if I understand clearly.
click
event listener subs to all open modals and portals and pass through all of them. SincedidClicknRootNodeClick
has been changed here,<Modal />
handles a click inhandleDocumentClick
and recognizes it as click ondimmer
. Everything is ok if<Modal />
will be withoutdimmer
or<Modal />
's content will be right under a click point.Version
0.77.2
Testcase
https://codesandbox.io/s/9y3wzpyjky
The text was updated successfully, but these errors were encountered: