-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: broken rerender on same name props' values #2460
Comments
@gitname the size of "massive" is not supported for the This is because that in SUI, there are no styles or class for that value on a popup, which can be seen here: https://semantic-ui.com/modules/popup.html#size |
Thanks for addressing this. You are correct: the Popup documentation does not show "massive" as a valid value for its When I created this issue, I was reading what I thought was the Popup docs, and saw "massive" listed as a valid value for the Lessons learned:
Sorry I did not do those things this time. I'll do them next time. |
@gitname I will reopen this issue since it sounds like there may be an issue with the docs. Might be the way some data is getting reused in the views. Thanks for checking back to look at this and including screenshots. |
@brianespinosa I managed to reproduce this "inconsistent docs" behavior again just now by doing the following:
On the other hand, when I did the above steps in the following order I'll be out again for a few hours, and will check this Issue this when I return. |
Here's a screencast GIF in which I demonstrate the issue: The screencast also contains a clue (I think) as to what's going on: I happened to select the |
Here's a screencast GIF that can serve as evidence that the web browser does consider them to be the same DOM elements. In this 40-second screencast, I modify |
I'm almost sure that problem is somewhere there, we use some HOCs that block rerenders, seems we have a problem there. |
size
value
FYI: I still see the issue happening at https://react.semantic-ui.com/. That may be because, although you've fixed it in the code, the version of the code containing the fix hasn't been deployed to https://react.semantic-ui.com/ yet. I don't know whether that's the case. |
Please submit a new issue with a complete report. |
This comment was updated on January 30, 2018, to reflect the more general issue that included the behavior described in the original comment. You can see the original comment below the horizontal line.
Updated comment:
Here is a description of the more general issue:
In the docs, when I visit the "Icon" page and then visit the "Popup" page, I see the
size
options from the former appear on the latter. For example, the option "massive" appears on the "Popup" page, where it does not belong.This behavior is demonstrated in the following screencast:
Original comment (created on January 24, 2018):
Steps
size
of "massive"Expected Result
The Chrome JavaScript console displays no warnings.
Actual Result
The Chrome JavaScript console displays the following warning:
Version
0.77.2
Testcase
Here's a demo of the issue:
https://codesandbox.io/s/101o69mrz7
The text was updated successfully, but these errors were encountered: