Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Modal): Incorrect display location of Modal with CSS 2.3.1 #2689

Closed
mgandley opened this issue Mar 27, 2018 · 3 comments
Closed

fix(Modal): Incorrect display location of Modal with CSS 2.3.1 #2689

mgandley opened this issue Mar 27, 2018 · 3 comments

Comments

@mgandley
Copy link
Contributor

Steps to Reproduce

  1. Use a modal.

Expected
The modal should be centered.

Result
The modal is not centered.

Testcase
Working: https://codepen.io/anon/pen/qopZBP
Not Working: https://codepen.io/anon/pen/qopZBP

Same code, only difference is using css 2.2.4 vs using css 2.3.1.

Not sure if this is an issue with the react library or the CSS, opening issue in both locations.

@welcome
Copy link

welcome bot commented Mar 27, 2018

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@brianespinosa
Copy link
Member

Duplicate of #2550

@brianespinosa brianespinosa marked this as a duplicate of #2550 Mar 27, 2018
@mgandley
Copy link
Contributor Author

mgandley commented Mar 27, 2018

Derp. #2250
Beaten by seconds. Thanks @brianespinosa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants